ref: 944150bafbbb5c3e807ba3688174e70764dbdc64
parent: bf2837a314eaf70135791984a423b0b09f58741d
author: Bjørn Erik Pedersen <bjorn.erik.pedersen@gmail.com>
date: Wed Nov 4 14:09:40 EST 2020
js: Remove external source map option It was merged by accident and the implementation does not look correct. Fixes #7932
--- a/resources/resource_transformers/js/build.go
+++ b/resources/resource_transformers/js/build.go
@@ -78,8 +78,7 @@
}
opts.sourcefile = ctx.SourcePath
- opts.workDir = t.c.rs.WorkingDir
- opts.resolveDir = opts.workDir
+ opts.resolveDir = t.c.rs.WorkingDir
opts.contents = string(src)
opts.mediaType = ctx.InMediaType
--- a/resources/resource_transformers/js/options.go
+++ b/resources/resource_transformers/js/options.go
@@ -93,7 +93,6 @@
contents string
sourcefile string
resolveDir string
- workDir string
tsConfig string
}
@@ -365,12 +364,6 @@
switch opts.SourceMap {case "inline":
sourceMap = api.SourceMapInline
- case "external":
- // When doing external sourcemaps we should specify
- // out file and no out dir
- sourceMap = api.SourceMapExternal
- outFile = filepath.Join(opts.workDir, opts.TargetPath)
- outDir = ""
case "":
sourceMap = api.SourceMapNone
default:
--- a/resources/resource_transformers/js/options_test.go
+++ b/resources/resource_transformers/js/options_test.go
@@ -93,7 +93,7 @@
opts, err = toBuildOptions(Options{Target: "es2018", Format: "cjs", Minify: true, mediaType: media.JavascriptType,
- SourceMap: "external"})
+ SourceMap: "inline"})
c.Assert(err, qt.IsNil)
c.Assert(opts, qt.DeepEquals, api.BuildOptions{Bundle: true,
@@ -102,7 +102,7 @@
MinifyIdentifiers: true,
MinifySyntax: true,
MinifyWhitespace: true,
- Sourcemap: api.SourceMapExternal,
+ Sourcemap: api.SourceMapInline,
Stdin: &api.StdinOptions{Loader: api.LoaderJS,
},