ref: 54abc9bade46e1e9532e1e984489bb6abdec74b0
parent: 85da20aab717b517b3e897b396a968306e560691
parent: 5bdf43407a630b6959afe1455fc74755843f3e4b
author: James Zern <jzern@google.com>
date: Tue Jun 4 17:12:50 EDT 2019
Merge changes Ib73136b2,Ie514f663 * changes: configure: enable -Wmissing-declarations for more files vp9_thread_test: quiet -Wmissing-prototypes
--- a/configure
+++ b/configure
@@ -620,6 +620,8 @@
check_add_cflags -Wcast-qual
check_add_cflags -Wvla
check_add_cflags -Wimplicit-function-declaration
+ check_add_cflags -Wmissing-declarations
+ check_add_cflags -Wmissing-prototypes
check_add_cflags -Wuninitialized
check_add_cflags -Wunused
check_add_cflags -Wextra
@@ -628,10 +630,6 @@
check_cflags -Wundef && add_cflags_only -Wundef
check_cflags -Wframe-larger-than=52000 && \
add_cflags_only -Wframe-larger-than=52000
- check_cflags -Wmissing-declarations && \
- add_cflags_only -Wmissing-declarations
- check_cflags -Wmissing-prototypes && \
- add_cflags_only -Wmissing-prototypes
if enabled mips || [ -z "${INLINE}" ]; then
enabled extra_warnings || check_add_cflags -Wno-unused-function
fi
--- a/examples.mk
+++ b/examples.mk
@@ -78,6 +78,8 @@
ifeq ($(CONFIG_LIBYUV),yes)
vpxdec.SRCS += $(LIBYUV_SRCS)
$(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-unused-parameter
+ $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-missing-declarations
+ $(BUILD_PFX)third_party/libyuv/%.cc.o: CXXFLAGS += -Wno-missing-prototypes
endif
ifeq ($(CONFIG_WEBM_IO),yes)
vpxdec.SRCS += $(LIBWEBM_COMMON_SRCS)
--- a/test/vp9_thread_test.cc
+++ b/test/vp9_thread_test.cc
@@ -196,6 +196,7 @@
// Note any worker that requires synchronization between other workers will
// hang.
namespace impl {
+namespace {
void Init(VPxWorker *const worker) { memset(worker, 0, sizeof(*worker)); }
int Reset(VPxWorker *const /*worker*/) { return 1; }
@@ -208,6 +209,7 @@
void Launch(VPxWorker *const worker) { Execute(worker); }
void End(VPxWorker *const /*worker*/) {}
+} // namespace
} // namespace impl
TEST(VPxWorkerThreadTest, TestSerialInterface) {