shithub: scc

Info  •  Files  •  Log  •  Branches

[libc] Fix strcmp() and strcoll()

If we want to support character encoding differents of ascii
we must to cast the operands to unsigned before doing the
substraction, or otherwise we can have wrong values.

--- a/libc/src/strcmp.c

+++ b/libc/src/strcmp.c

@@ -7,5 +7,5 @@

 {

 	while (*s1 && *s2 && *s1 != *s2)

 		++s1, ++s2;

-	return *s1 - *s2;

+	return *(unsigned char *)s1 - *(unsigned char *)s2;

 }

--- a/libc/src/strcoll.c

+++ b/libc/src/strcoll.c

@@ -7,5 +7,5 @@

 {

 	while (*s1 && *s2 && *s1 != *s2)

 		++s1, ++s2;

-	return *s1 - *s2;

+	return *(unsigned char *) s1 - *(unsigned char *) s2;

 }