shithub: choc

Download patch

ref: 24a33a805b51af0dec3be1bdcffa3dc9c3f524e2
parent: e3c5d70d8ae4e2dc103642eefa149fa4af94f986
author: Simon Howard <fraggle@gmail.com>
date: Sun Apr 6 22:22:37 EDT 2014

music: Suggest using .ogg format, not .mp3.

Using the .mp3 extension in generated music config files carries an
implicit recommendation to use that format. There are a number of
reasons to prefer other formats. The biggest is that MP3 is patent
encumbered. Furthermore, while FLAC and Ogg Vorbis both support the
Vorbis comment format that allows metadata loop point tags to be
specified.

--- a/src/i_sdlmusic.c

+++ b/src/i_sdlmusic.c

@@ -390,7 +390,7 @@

             fprintf(fs, "%02x", digest[h]);

         }

-        fprintf(fs, " = %s.mp3\n", name);

+        fprintf(fs, " = %s.ogg\n", name);

     }

     fprintf(fs, "\n");