shithub: choc

Info  •  Files  •  Log  •  Branches

net: explicitly declare a bit-shifted 1 literal as unsigned

This fixes a future "Shifting signed 32-bit value by 31 bits is
undefined behaviour" cppcheck error.

--- a/src/net_packet.c

+++ b/src/net_packet.c

@@ -158,10 +158,10 @@

 {

     if (NET_ReadInt32(packet, (unsigned int *) data))

     {

-        if (*data & (1 << 31))

+        if (*data & (1U << 31))

         {

-            *data &= ~(1 << 31);

-            *data -= (1 << 31);

+            *data &= ~(1U << 31);

+            *data -= (1U << 31);

         }

         return true;

     }