shithub: choc

Download patch

ref: 748e992f79d73d2f0770ea783be7e0e068d81f6a
parent: 25ce5f9c2b723a39c9b97079b4a2fd5a09b057ec
author: Jonathan Dowland <jon+github@alcopop.org>
date: Tue Mar 1 17:34:09 EST 2016

Remove remaining setpanning_workaround code

Finish removing an old compatibility check setpanning_workaround,
completing work begun in d721228ed1a9df515d51c2d57ea3f7199f86daa5.

--- a/src/i_sdlsound.c
+++ b/src/i_sdlsound.c
@@ -56,8 +56,6 @@
     allocated_sound_t *prev, *next;
 };
 
-static boolean setpanning_workaround = false;
-
 static boolean sound_initialized = false;
 
 static allocated_sound_t *channels_playing[NUM_CHANNELS];
@@ -898,16 +896,6 @@
     else if ( left > 255) left = 255;
     if (right < 0) right = 0;
     else if (right > 255) right = 255;
-
-    // SDL_mixer version 1.2.8 and earlier has a bug in the Mix_SetPanning
-    // function.  A workaround is to call Mix_UnregisterAllEffects for
-    // the channel before calling it.  This is undesirable as it may lead
-    // to the channel volumes resetting briefly.
-
-    if (setpanning_workaround)
-    {
-        Mix_UnregisterAllEffects(handle);
-    }
 
     Mix_SetPanning(handle, left, right);
 }