shithub: choc

Info  •  Files  •  Log  •  Branches

fix a cppcheck warning for M_DirName() and M_BaseName() (#1524)

* fix a cppcheck warning for M_DirName() and M_BaseName()

* fix pb and pf pointer checking order

* simplify matters

--- a/src/m_misc.c

+++ b/src/m_misc.c

@@ -505,7 +505,7 @@

     }

     else

     {

-        const char *p = (pf > pb) ? pf : pb;

+        const char *p = (pb > pf) ? pb : pf;

         result = M_StringDuplicate(path);

         result[p - path] = '\0';

         return result;

@@ -531,7 +531,7 @@

     }

     else

     {

-        const char *p = (pf > pb) ? pf : pb;

+        const char *p = (pb > pf) ? pb : pf;

         return p + 1;

     }

 }

@@ -916,4 +916,4 @@

             }

         }

     }

-}

\ No newline at end of file

+}