shithub: choc

Download patch

ref: a8c4c51deeb59783c54fe40f3f47018712527ad3
parent: d811a1bec4ec09153ee6fcf376e2a10ca3a274a2
author: Jonathan Dowland <jon+github@alcopop.org>
date: Mon Jul 6 17:41:24 EDT 2015

snd_pitchshift defaults off, except Raven games

Tweak snd_pitchshift to clearly default to off and switch the
default to on only for Heretic and Hexen (since all versions of
Heretic and Hexen did pitch-shifting).

Pitch shifting was never implemented for Strife, so hide the option
in chocolate-strife-setup entirely.

--- a/src/setup/sound.c
+++ b/src/setup/sound.c
@@ -290,6 +290,14 @@
         num_music_modes = NUM_MUSICMODES - 1;
     }
 
+    // All versions of Heretic and Hexen did pitch-shifting.
+    // Most versions of Doom did not and Strife never did.
+
+    if(gamemission == heretic || gamemission == hexen)
+    {
+        snd_pitchshift = 1;
+    }
+
     // Build the window
 
     window = TXT_NewWindow("Sound configuration");
@@ -315,8 +323,15 @@
                    TXT_NewSpinControl(&numChannels, 1, 8),
                    TXT_NewLabel("SFX volume"),
                    TXT_NewSpinControl(&sfxVolume, 0, 15),
-                   TXT_NewCheckBox("Pitch-shift sounds", &snd_pitchshift),
                    NULL);
+
+    // strife did not implement pitch shifting at all, so hide the option.
+
+    if (gamemission != strife)
+    {
+        TXT_AddWidget(sfx_table,
+                   TXT_NewCheckBox("Pitch-shift sounds", &snd_pitchshift));
+    }
 
     if (gamemission == strife)
     {