shithub: choc

Download patch

ref: b07602b54dfb30d8f708901f41e1f2fce2ed2961
parent: 0b4df30a99ac27177fef1c254fe26943c4859aac
author: Simon Howard <fraggle@gmail.com>
date: Sun Oct 27 20:25:41 EDT 2013 

Fix Vanilla behavior of shift key when entering savegame names in the
menu (thanks Alexandre Xavier).

Subversion-branch: /branches/v2-branch
Subversion-revision: 2723


--- a/src/doom/m_menu.c
+++ b/src/doom/m_menu.c
@@ -1586,9 +1586,19 @@
 	    if (savegamestrings[saveSlot][0])
 		M_DoSave(saveSlot);
 	    break;
-				
+
 	  default:
-	    // Entering a character - use the 'ch' value, not the key
+            // This is complicated.
+            // Vanilla has a bug where the shift key is ignored when entering
+            // a savegame name. If vanilla_keyboard_mapping is on, we want
+            // to emulate this bug by using 'data1'. But if it's turned off,
+            // it implies the user doesn't care about Vanilla emulation: just
+            // use the correct 'data2'.
+
+            if (vanilla_keyboard_mapping)
+            {
+                ch = key;
+            }
 
             ch = toupper(ch);
 
--- a/src/strife/m_menu.c
+++ b/src/strife/m_menu.c
@@ -1869,7 +1869,17 @@
             break;
 
         default:
-            // Entering a character - use the 'ch' value, not the key
+            // This is complicated.
+            // Vanilla has a bug where the shift key is ignored when entering
+            // a savegame name. If vanilla_keyboard_mapping is on, we want
+            // to emulate this bug by using 'data1'. But if it's turned off,
+            // it implies the user doesn't care about Vanilla emulation: just
+            // use the correct 'data2'.
+
+            if (vanilla_keyboard_mapping)
+            {
+                ch = key;
+            }
 
             ch = toupper(ch);