ref: a3278a60b5c56d1e3305bdcb4665fba7b141651b
parent: 24d104e2e812a91f3e1d7e4b4dc8b5adf8a74fbc
author: Clownacy <Clownacy@users.noreply.github.com>
date: Fri Jul 19 15:19:35 EDT 2019
A fix, some documentation, and cleanup
--- a/src/Draw.cpp
+++ b/src/Draw.cpp
@@ -181,7 +181,7 @@
if (surf_no >= SURFACE_ID_MAX)
{- printf("Tried to load bitmap at invalid slot (%d - maximum is %d\n", surf_no, SURFACE_ID_MAX);+ printf("Tried to load bitmap at invalid slot (%d - maximum is %d)\n", surf_no, SURFACE_ID_MAX);}
else
{--- a/src/TextScr.cpp
+++ b/src/TextScr.cpp
@@ -43,7 +43,7 @@
TEXT_SCRIPT gTS;
-int gNumberTextScript[4];
+int gNumberTextScript[4]; // Seems to be for debugging
char text[0x100];
RECT gRect_line = {0, 0, 216, 16};@@ -637,8 +637,14 @@
{w = GetTextScriptNo(gTS.p_read + 4);
x = GetTextScriptNo(gTS.p_read + 9);
+
+ // Looks like Pixel left some debug code in. Oops.
gNumberTextScript[0] = x;
+ #ifndef FIX_BUGS
+ // z is uninitialised. Probably a leftover from copypasting.
gNumberTextScript[1] = z;
+ #endif
+
PlaySoundObject(38, 1);
AddArmsData(w, x);
gTS.p_read += 13;
@@ -1211,6 +1217,11 @@
}
else if (IS_COMMAND('N','U','M')) {+ // This seems to be a command used for debugging TSC scripts:
+ // It prints a selected char in the gNumberTextScript array.
+ // gNumberTextScript is only used by the '<AM+' command, and
+ // even then, part of it's assigned to an uninitialised
+ // variable, while the other half of it is completely unused.
z = GetTextScriptNo(gTS.p_read + 4);
SetNumberTextScript(z);
gTS.p_read += 8;