shithub: cstory

Download patch

ref: f7a3eee9b511301e89ec0d62a83bea218f2e57a2
parent: 9461b141f1efa82239c7f3045a10f3b1c3b7b5da
author: Gabriel Ravier <gabravier@gmail.com>
date: Sun Nov 10 08:09:05 EST 2019

betterComments : Some stuff for the PR to accurate

Signed-off-by: Gabriel Ravier <gabravier@gmail.com>

--- a/src/NpcAct160.cpp
+++ b/src/NpcAct160.cpp
@@ -69,8 +69,8 @@
 			break;
 
 		case 3:
-			npc->damage = 20;
-			npc->damage = 0;	// Duplicate line
+			npc->damage = 20;	// Overriden by the following line
+			npc->damage = 0;
 
 			if (++npc->act_wait > 24)
 			{
--- a/src/NpcAct260.cpp
+++ b/src/NpcAct260.cpp
@@ -1291,8 +1291,6 @@
 		case 51:
 			if (++npc->act_wait > 30 && npc->act_wait % 4 == 1)
 			{
-				// The range of unsigned char is [0, 255] so these two values are implicitly truncated (Might be UB ?)
-				// TODO : Investigate on whether this is erroneous
 				if (npc->direct == 0)
 					deg = 0x88;
 				else