shithub: pokecrystal

Download patch

ref: 158144f9cbebdb076262dc45c05253cb8fbc1acf
parent: 51bbfee89192cd93c49e3c400ca8745cc3e77e30
author: i0brendan0 <19826742+i0brendan0@users.noreply.github.com>
date: Fri Jun 1 21:12:52 EDT 2018

undo protect message bug

--- a/docs/bugs_and_glitches.md
+++ b/docs/bugs_and_glitches.md
@@ -53,7 +53,6 @@
 - [`TryObjectEvent` arbitrary code execution](#tryobjectevent-arbitrary-code-execution)
 - [`Special_CheckBugContestContestantFlag` can read beyond its data table](#special_checkbugcontestcontestantflag-can-read-beyond-its-data-table)
 - [`ClearWRAM` only clears WRAM bank 1](#clearwram-only-clears-wram-bank-1)
-- [Moves erroneously say they have missed when the opponent uses Protect or Detect](#moves-erroneously-say-they-have-missed-when-the-opponent-uses-protect-or-detect)
 
 
 ## Thick Club and Light Ball can decrease damage done with boosted (Special) Attack
@@ -1493,29 +1492,3 @@
 ```
 
 **Fix:** Change `jr nc, .bank_loop` to `jr c, .bank_loop`.
-
-## Moves erroneously say they have missed when the opponent uses Protect or Detect
-
-In [battle/effect_commands.asm](battle/effect_commands.asm):
-
-```asm
-BattleCommand_CheckHit: ; 34d32
-; checkhit
-
-	call .DreamEater
-	jp z, .Miss
-
-	call .Protect
-	jp nz, .Miss
-```
-
-**Fix:** Change `jp nz, .Miss` to `jp nz, .Failed` and add
-
-```asm
-.Failed:
-    ld a, 1
-    ld [wEffectFailed], a
-    ret
-```
-
-at [line 1781](battle/effect_commands.asm#L1718).