ref: 4046b41c3aaaf0d930f0268e52112aa7ea01e0a4
parent: b35eb72290b964b98844afbe741bb7ede34b9ef3
parent: 8b007e8d51ec86992d97fa4b1c05b762e0916427
author: yenatch <yenatch@gmail.com>
date: Thu Feb 15 16:14:22 EST 2018
Merge pull request #487 from luckytyphlosion/master Fix more w-izing edge cases.
--- a/data/trainers/palettes.asm
+++ b/data/trainers/palettes.asm
@@ -1,7 +1,7 @@
TrainerPalettes: ; b0ce
; entries correspond to trainer classes
-wPlayerPalette: ; Chris uses the same colors as Cal
+PlayerPalette: ; Chris uses the same colors as Cal
INCLUDE "gfx/trainers/cal.pal"
KrisPalette: ; Kris shares Falkner's palette
INCLUDE "gfx/trainers/falkner.pal"
--- a/engine/color.asm
+++ b/engine/color.asm
@@ -716,7 +716,7 @@
ret
.male
- ld hl, wPlayerPalette
+ ld hl, PlayerPalette
ret
GetFrontpicPalettePointer:
--- a/engine/overworld.asm
+++ b/engine/overworld.asm
@@ -233,9 +233,9 @@
cp SPRITE_POKEMON
jr c, .Normal
cp SPRITE_DAY_CARE_MON_1
- jr z, .wBreedMon1
+ jr z, .BreedMon1
cp SPRITE_DAY_CARE_MON_2
- jr z, .wBreedMon2
+ jr z, .BreedMon2
cp SPRITE_VARS
jr nc, .Variable
jr .Icon
@@ -253,11 +253,11 @@
ld a, [hl]
jr .Mon
-.wBreedMon1
+.BreedMon1
ld a, [wBreedMon1Species]
jr .Mon
-.wBreedMon2
+.BreedMon2
ld a, [wBreedMon2Species]
.Mon:
--- a/engine/pack.asm
+++ b/engine/pack.asm
@@ -1148,7 +1148,7 @@
; entries correspond to *_POCKET constants
dw .Items
dw .Balls
- dw .wKeyItems
+ dw .KeyItems
dw .TMHM
.Items: ; 107e9 (4:47e9)
@@ -1174,7 +1174,7 @@
dba UpdateItemDescription
; 10807
-.wKeyItems: ; 10807 (4:4807)
+.KeyItems: ; 10807 (4:4807)
ld a, KEY_ITEM_POCKET
ld hl, .KeyItemsMenuDataHeader
jr .DisplayPocket
--- a/home/serial.asm
+++ b/home/serial.asm
@@ -200,7 +200,7 @@
cp SERIAL_NO_DATA_BYTE
ret nz
call CheckwLinkTimeoutFramesNonzero
- jr z, .wLinkTimeoutFrames_zero
+ jr z, .linkTimeoutFrames_zero
push hl
ld hl, wLinkTimeoutFrames + 1
ld a, [hl]
@@ -215,7 +215,7 @@
call CheckwLinkTimeoutFramesNonzero
jr z, SerialDisconnected
-.wLinkTimeoutFrames_zero
+.linkTimeoutFrames_zero
ld a, [rIE]
and (1 << SERIAL) | (1 << TIMER) | (1 << LCD_STAT) | (1 << VBLANK)
cp 1 << SERIAL
--- a/maps/KrissHouse2F.asm
+++ b/maps/KrissHouse2F.asm
@@ -34,19 +34,19 @@
db 0, 0, 0 ; filler
-Doll1:
+DecoDoll1Script:
describedecoration DECODESC_LEFT_DOLL
-Doll2:
+DecoDoll2Script:
describedecoration DECODESC_RIGHT_DOLL
-wDecoBigDoll:
+DecoBigDollScript:
describedecoration DECODESC_BIG_DOLL
-GameConsole:
+DecoGameConsoleScript:
describedecoration DECODESC_CONSOLE
-KrissHousePoster:
+DecoPosterScript:
conditional_event EVENT_KRISS_ROOM_POSTER, .Script
.Script:
@@ -131,11 +131,11 @@
bg_event 2, 1, BGEVENT_UP, KrissHousePC
bg_event 3, 1, BGEVENT_READ, KrissHouseRadio
bg_event 5, 1, BGEVENT_READ, KrissHouseBookshelf
- bg_event 6, 0, BGEVENT_IFSET, KrissHousePoster
+ bg_event 6, 0, BGEVENT_IFSET, DecoPosterScript
.ObjectEvents:
db 4
- object_event 4, 2, SPRITE_CONSOLE, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, GameConsole, EVENT_KRISS_HOUSE_2F_CONSOLE
- object_event 4, 4, SPRITE_DOLL_1, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, Doll1, EVENT_KRISS_HOUSE_2F_DOLL_1
- object_event 5, 4, SPRITE_DOLL_2, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, Doll2, EVENT_KRISS_HOUSE_2F_DOLL_2
- object_event 0, 1, SPRITE_BIG_DOLL, SPRITEMOVEDATA_BIGDOLL, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, wDecoBigDoll, EVENT_KRISS_HOUSE_2F_BIG_DOLL
+ object_event 4, 2, SPRITE_CONSOLE, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, DecoGameConsoleScript, EVENT_KRISS_HOUSE_2F_CONSOLE
+ object_event 4, 4, SPRITE_DOLL_1, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, DecoDoll1Script, EVENT_KRISS_HOUSE_2F_DOLL_1
+ object_event 5, 4, SPRITE_DOLL_2, SPRITEMOVEDATA_ITEM_TREE, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, DecoDoll2Script, EVENT_KRISS_HOUSE_2F_DOLL_2
+ object_event 0, 1, SPRITE_BIG_DOLL, SPRITEMOVEDATA_BIGDOLL, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, DecoBigDollScript, EVENT_KRISS_HOUSE_2F_BIG_DOLL
--- a/mobile/mobile_5b.asm
+++ b/mobile/mobile_5b.asm
@@ -200,7 +200,7 @@
ld bc, 20
xor a
call ByteFill
- ld hl, .wTileMap
+ ld hl, .TileMap
decoord 0, 1
ld bc, $0154
call CopyBytes
@@ -212,7 +212,7 @@
ld bc, SCREEN_WIDTH
xor a
call ByteFill
- ld hl, .wAttrMap
+ ld hl, .AttrMap
decoord 0, 1, wAttrMap
ld bc, 17 * SCREEN_WIDTH
call CopyBytes
@@ -222,10 +222,10 @@
.Tiles:
INCBIN "gfx/mobile/mobile_splash.2bpp"
-.wTileMap:
+.TileMap:
INCBIN "gfx/mobile/mobile_splash.tilemap"
-.wAttrMap:
+.AttrMap:
INCBIN "gfx/mobile/mobile_splash.attrmap"
UnknownMobilePalettes_16c903: ; 16c903