ref: 4387298b2c71c0379dd1b4c2a4a2e911f822b9cc
parent: 8fd66c080f201c401419674229f2714853de008f
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Wed Dec 14 17:30:20 EST 2022
Comment the Crystal 1.0 bugs as "BUG:" too
--- a/engine/events/battle_tower/load_trainer.asm
+++ b/engine/events/battle_tower/load_trainer.asm
@@ -30,8 +30,8 @@
maskbits BATTLETOWER_NUM_UNIQUE_TRAINERS
cp BATTLETOWER_NUM_UNIQUE_TRAINERS
else
-; Crystal 1.0 used the wrong constant here, so only the first 21
-; trainers in BattleTowerTrainers can be sampled.
+; BUG: Crystal 1.0 used the wrong constant here, so only the first
+; 21 trainers in BattleTowerTrainers can be sampled.
maskbits BATTLETOWER_NUM_UNIQUE_MON
cp BATTLETOWER_NUM_UNIQUE_MON
endc
--- a/engine/events/battle_tower/trainer_text.asm
+++ b/engine/events/battle_tower/trainer_text.asm
@@ -10,10 +10,9 @@
if DEF(_CRYSTAL11)
ld hl, wBT_OTTrainerClass
else
-; BUG ALERT
-; Instead of loading the Trainer Class, this routine
-; loads the 6th character in the Trainer's name, then
-; uses it to get the gender of the trainer.
+; BUG: Instead of loading the trainer class,
+; Crystal 1.0 loads the 6th character in the trainer's
+; name, then uses it to get the trainer's gender.
; As a consequence, the enemy trainer's dialog will
; always be sampled from the female array.
ld hl, wBT_OTName + NAME_LENGTH_JAPANESE - 1
--- a/mobile/mobile_5c.asm
+++ b/mobile/mobile_5c.asm
@@ -867,8 +867,8 @@
Stadium2N64Tilemap:
if DEF(_CRYSTAL11)
-; Crystal 1.1 corrupted this tilemap by treating $0a bytes as Unix newlines,
-; and converting them to $0d $0a Windows newlines.
+; BUG: Crystal 1.1 corrupted this tilemap by treating $0a bytes as
+; Unix newlines, and converting them to $0d $0a Windows newlines.
INCBIN "gfx/mobile/stadium2_n64_corrupt.tilemap"
else
INCBIN "gfx/mobile/stadium2_n64.tilemap"
--- a/ram/wram.asm
+++ b/ram/wram.asm
@@ -743,7 +743,8 @@
wPokedexStatus:: db
wPokedexDataEnd::
else
-wPokedexDataEnd:: ds 1
+wPokedexDataEnd::
+ ds 1
endc
ds 2
@@ -1538,8 +1539,10 @@
if DEF(_CRYSTAL11)
wPrevDexEntryBackup:: db
else
-wPrevDexEntryBackup::
-wPokedexStatus:: db
+; BUG: Crystal 1.0 reused the same byte in WRAM for
+; wPokedexStatus and wPrevDexEntryBackup.
+wPokedexStatus::
+wPrevDexEntryBackup:: db
endc
wUnusedPokedexByte:: db