shithub: pokecrystal

Download patch

ref: a91aa18daeb7fdd24fe512468d549ca49fe524fc
parent: 1840af8b4f02d6b8f748ea917344c64cb1c5ff2d
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Wed May 23 18:13:46 EDT 2018

Use constants more

--- a/engine/overworld/map_objects.asm
+++ b/engine/overworld/map_objects.asm
@@ -2574,7 +2574,7 @@
 
 _SetPlayerPalette: ; 57e2
 	ld a, d
-	and %10000000
+	and 1 << 7
 	ret z
 	ld bc, 0 ; debug?
 	ld hl, OBJECT_FACING
@@ -2584,13 +2584,13 @@
 	ld [hl], a
 	ld a, d
 	swap a
-	and %00000111
+	and PALETTE_MASK
 	ld d, a
 	ld bc, wPlayerStruct
 	ld hl, OBJECT_PALETTE
 	add hl, bc
 	ld a, [hl]
-	and %11111000
+	and $ff ^ PALETTE_MASK
 	or d
 	ld [hl], a
 	ret