shithub: pokecrystal

Download patch

ref: be28a0ff4eb4ba04dcbd0fc025b3a68af535a0a1
parent: 60add76ee7b74fac4067feb0451eac2b8cf35a03
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Sun Feb 25 14:50:48 EST 2018

Meaningful $ff values

--- a/engine/battle/core.asm
+++ b/engine/battle/core.asm
@@ -3324,7 +3324,7 @@
 ; 3d599
 
 FindPkmnInOTPartyToSwitchIntoBattle: ; 3d599
-	ld b, $ff
+	ld b, -1
 	ld a, $1
 	ld [wBuffer1], a
 	ld [wBuffer2], a
@@ -3468,7 +3468,7 @@
 	ld a, [wBuffer1]
 	and a
 	jr z, .okay2
-	ld b, $ff
+	ld b, -1
 	ld c, a
 .loop3
 	inc b
@@ -3477,7 +3477,7 @@
 	jr .quit
 
 .okay2
-	ld b, $ff
+	ld b, -1
 	ld a, [wBuffer2]
 	ld c, a
 .loop4
@@ -8849,13 +8849,13 @@
 
 .caught_or_defeated_roam_mon
 	call GetRoamMonHP
-	ld [hl], $0
+	ld [hl], 0
 	call GetRoamMonMapGroup
-	ld [hl], $ff
+	ld [hl], GROUP_N_A
 	call GetRoamMonMapNumber
-	ld [hl], $ff
+	ld [hl], MAP_N_A
 	call GetRoamMonSpecies
-	ld [hl], $0
+	ld [hl], 0
 	ret
 
 .not_roaming