ref: d2880d1981876b06bc867ae17376e31f2d4df60d
parent: ad5337863ddbb7b821f57a0c8af2c767cc767f19
author: Rangi <remy.oukaour+rangi42@gmail.com>
date: Wed May 23 07:08:23 EDT 2018
Factor out GetHPPals and SetHPPals from home.asm The remaining code in home.asm is almost all "generic", unrelated to Pokémon-specific game logic, so leaving it as-is might be neater than little home/*.asm files for each routine.
--- a/home.asm
+++ b/home.asm
@@ -227,26 +227,7 @@
; 31f3
INCLUDE "home/tilemap.asm"
-
-SetHPPal:: ; 334e
-; Set palette for hp bar pixel length e at hl.
- call GetHPPal
- ld [hl], d
- ret
-; 3353
-
-GetHPPal:: ; 3353
-; Get palette for hp bar pixel length e in d.
- ld d, HP_GREEN
- ld a, e
- cp (50 * 48 / 100)
- ret nc
- inc d ; HP_YELLOW
- cp (21 * 48 / 100)
- ret nc
- inc d ; HP_RED
- ret
-; 335f
+INCLUDE "home/hp_pals.asm"
CountSetBits:: ; 0x335f
; Count the number of set bits in b bytes starting from hl.
--- /dev/null
+++ b/home/hp_pals.asm
@@ -1,0 +1,19 @@
+SetHPPal:: ; 334e
+; Set palette for hp bar pixel length e at hl.
+ call GetHPPal
+ ld [hl], d
+ ret
+; 3353
+
+GetHPPal:: ; 3353
+; Get palette for hp bar pixel length e in d.
+ ld d, HP_GREEN
+ ld a, e
+ cp (50 * 48 / 100)
+ ret nc
+ inc d ; HP_YELLOW
+ cp (21 * 48 / 100)
+ ret nc
+ inc d ; HP_RED
+ ret
+; 335f