shithub: rgbds

Info  •  Files  •  Log  •  Branches

Change comment style and use errx instead of err

--- a/src/link/patch.c

+++ b/src/link/patch.c

@@ -85,14 +85,16 @@

 		static const size_t increase_factor = 2;

 		if (stack.capacity > SIZE_MAX / increase_factor)

-			err(1, "Overflow in RPN stack resize");

+			errx(1, "Overflow in RPN stack resize");

 		stack.capacity *= increase_factor;

 		stack.buf =

 			realloc(stack.buf, sizeof(*stack.buf) * stack.capacity);

-		// || !stack.capacity to fix bogus

-		// zero-size allocation warning from

-		// scan-build, already caught above

+		/*

+		 * Static analysis tools complain that the capacity might become

+		 * zero due to overflow, but fail to realize that it's caught by

+		 * the overflow check above. Hence the stringent check below.

+		 */

 		if (!stack.buf || !stack.capacity)

 			err(1, "Failed to resize RPN stack");

 	}