shithub: rgbds

Download patch

ref: b02ccf8f4a06d750d1638af30c06a51e0e7c4f06
parent: 2e0991f32bc043793d2ca1c6b7ababd1c6a6a40f
author: ISSOtm <eldredhabert0@gmail.com>
date: Thu Aug 4 16:37:36 EDT 2022

Check before attempting to generate empty image

This causes a libpng warning then error, but print a better error message
Fixes #1016

--- a/include/gfx/main.hpp
+++ b/include/gfx/main.hpp
@@ -21,7 +21,7 @@
 #include "gfx/rgba.hpp"
 
 struct Options {
-	uint16_t reversedWidth = 0; // -r, in pixels
+	uint16_t reversedWidth = 0; // -r, in tiles
 	bool reverse() const { return reversedWidth != 0; }
 
 	bool useColorCurve = false; // -C
--- a/src/gfx/reverse.cpp
+++ b/src/gfx/reverse.cpp
@@ -122,6 +122,9 @@
 		options.verbosePrint(Options::VERB_INTERM, "Read %zu tilemap entries.\n", nbTileInstances);
 	}
 
+	if (nbTileInstances == 0) {
+		fatal("Cannot generate empty image");
+	}
 	if (nbTileInstances > options.maxNbTiles[0] + options.maxNbTiles[1]) {
 		warning("Read %zu tiles, more than the limit of %zu + %zu", nbTileInstances,
 		        options.maxNbTiles[0], options.maxNbTiles[1]);