shithub: riscv

Info  •  Files  •  Log  •  Branches

ape/mv: check if from path fits and error if too long

--- a/sys/src/ape/cmd/mv.c

+++ b/sys/src/ape/cmd/mv.c

@@ -85,7 +85,13 @@

 	char *fromdir, *fromelem;

 	Dir *dirt, null;

-	strncpy(fromname, from, sizeof fromname);

+	i = strlen(from);

+	if(i >= sizeof(fromname)){

+		fprint(2, "mv: path too big (max %d): %s\n",

+			sizeof(fromname), from);

+		return -1;

+	}

+	memmove(fromname, from, i+1);

 	split(from, &fromdir, &fromelem);

 	if(toelem == 0)

 		toelem = fromelem;

-- 

⑨