shithub: riscv

Info  •  Files  •  Log  •  Branches

abaco: fix double free race of p->status string (thanks BurnZeZ for the proc snap)

--- a/sys/src/cmd/abaco/util.c

+++ b/sys/src/cmd/abaco/util.c

@@ -962,12 +962,12 @@

 	if(s == nil)

 		error("runevsmprint failed");

+	qlock(&refreshlock);

 	if(p->status){

 		free(p->status);

 		p->status = nil;

 	}

 	p->status = s;

-	qlock(&refreshlock);

 	for(r=refreshs; r!=nil; r=r->next)

 		if(r->p == p)

 			goto Return;