shithub: riscv

Info  •  Files  •  Log  •  Branches

kernel: add extra negative and power-of-two check to pcibarsize()

--- a/sys/src/9/port/pci.c

+++ b/sys/src/9/port/pci.c

@@ -190,16 +190,16 @@

 			pcicfgrw32(p->tbdf, rno, v, 0);

 		}

 	}

+	size = -size;

 	iunlock(&pcicfglock);

-	if(size > 0){

-		print("pcibarsize: %T invalid bar rno %x mask %llux\n",

-			p->tbdf, rno, (uvlong)size);

+	if(size < 0 || (size & size-1) != 0){

+		print("pcibarsize: %T invalid bar rno %#x size %#llux mask %#llux\n",

+			p->tbdf, rno, size, -size);

 		return 0;

 	}

-

-	return -size;

+	return size;

 }

 void