shithub: riscv

Info  •  Files  •  Log  •  Branches

upas/fs: fix swapped argument, dead code

With ntlm auth, we were trying to set 0 bytes of
the auth struct to its size. The args were clearly
swapped. Fix it.

While we're here, remove some dead code.

--- a/sys/src/cmd/upas/fs/imap.c

+++ b/sys/src/cmd/upas/fs/imap.c

@@ -687,8 +687,7 @@

 		return "auth_respond failed";

 	/* prepare NtLmAuthenticate blob */

-

-	memset(buf, sizeof buf, 0);

+	memset(buf, 0, sizeof(buf));

 	p = buf;

 	ep = p + 8 + 6*8 + 2*4;

 	q = ep;

@@ -850,14 +849,6 @@

 		return err;

 	}

 	return nil;

-}

-

-static void

-imap4hangup(Imap *imap)

-{

-	imap4cmd(imap, "logout");

-	imap4resp(imap);

-	imap4disconnect(imap);

 }

 /* gmail lies about message sizes */

-- 

⑨