shithub: libopusenc

Info  •  Files  •  Log  •  Branches

Calling srand() was probably not a good idea

Not a good thing to do from a library and if chains are short, we get the
same random number twice, which is even worse.

--- a/src/opusenc.c

+++ b/src/opusenc.c

@@ -275,15 +275,11 @@

 }

 static void init_stream(OggOpusEnc *enc) {

-  time_t start_time;

   assert(!enc->streams->stream_is_init);

   if (!enc->streams->serialno_is_set) {

-    start_time = time(NULL);

-    srand(((getpid()&65535)<<15)^start_time);

-

     enc->streams->serialno = rand();

   }

-  

+

   if (ogg_stream_init(&enc->streams->os, enc->streams->serialno) == -1) {

     assert(0);

     /* FIXME: How the hell do we handle that? */