shithub: opus-tools

Info  •  Files  •  Log  •  Branches

Fix copying pictures from FLAC with a mimetype.

If the METADATA_BLOCK_PICTURE field contained a non-empty mimetype
 or description field, then we would overwrite important pieces of
 the struct when encoding, making the tag useless.

--- a/src/flac.c

+++ b/src/flac.c

@@ -207,11 +207,11 @@

         offs+=4;

         WRITE_U32_BE(buf+offs,(FLAC__uint32)mime_type_length);

         offs+=4;

-        memcpy(buf,metadata->data.picture.mime_type,mime_type_length);

+        memcpy(buf+offs,metadata->data.picture.mime_type,mime_type_length);

         offs+=mime_type_length;

         WRITE_U32_BE(buf+offs,(FLAC__uint32)description_length);

         offs+=4;

-        memcpy(buf,metadata->data.picture.description,description_length);

+        memcpy(buf+offs,metadata->data.picture.description,description_length);

         offs+=description_length;

         WRITE_U32_BE(buf+offs,metadata->data.picture.width);

         offs+=4;