shithub: dav1d

Info  •  Files  •  Log  •  Branches

dav1dplay: don't freeze on render errors

Returning out of this function when pl_render_image() fails is the wrong
thing to do, since that leaves the swapchain frame acquired but never
submitted. Instead, just clear the target FBO to blank red (to make it
clear that something went wrong) and continue on with presentation.

--- a/examples/dp_renderer_placebo.c

+++ b/examples/dp_renderer_placebo.c

@@ -328,8 +328,7 @@

     if (!pl_render_image(rd_priv_ctx->renderer, &rd_priv_ctx->image, &target, &render_params)) {

         fprintf(stderr, "Failed rendering frame!\n");

-        SDL_UnlockMutex(rd_priv_ctx->lock);

-        return;

+        pl_tex_clear(rd_priv_ctx->gpu, target.fbo, (float[4]){ 1.0 });

     }

     ok = pl_swapchain_submit_frame(rd_priv_ctx->swapchain);