shithub: flite

Info  •  Files  •  Log

Only write audio data to a temporariy file in debug builds

This isn't useful in regular builds and is actually a security concern,
although it seems (see discussion in [Bug-Debian]) that this is most likely
only reached during testsuite calls.

CVE-2014-0027

Original patch from Rui Matos <tiagomatos@gmail.com>
Date: Mon, 6 Jan 2014 13:45:00 +0000
Bug-Debian: http://bugs.debian.org/734746
Bug-Redhat: https://bugzilla.redhat.com/show_bug.cgi?id=1048678
Source: https://bugzilla.redhat.com/attachment.cgi?id=846118

--- a/src/audio/auserver.c

+++ b/src/audio/auserver.c

@@ -67,9 +67,11 @@

     int q,i,n,r;

     unsigned char bytes[CST_AUDIOBUFFSIZE];

     short shorts[CST_AUDIOBUFFSIZE];

+#ifdef DEBUG

     cst_file fff;

     fff = cst_fopen("/tmp/awb.wav",CST_OPEN_WRITE|CST_OPEN_BINARY);

+#endif

     if ((audio_device = audio_open(header->sample_rate,1,

 				   (header->encoding == CST_SND_SHORT) ?

@@ -116,7 +118,9 @@

 	for (q=r; q > 0; q-=n)

 	{

 	    n = audio_write(audio_device,shorts,q);

+#ifdef DEBUG

 	    cst_fwrite(fff,shorts,2,q);

+#endif

 	    if (n <= 0)

 	    {

 		audio_close(audio_device);

@@ -125,7 +129,9 @@

 	}

     }

     audio_close(audio_device);

+#ifdef DEBUG

     cst_fclose(fff);

+#endif

     return CST_OK_FORMAT;