shithub: openh264

Info  •  Files  •  Log  •  Branches

memset not required as struct is already initialized to 0.

Moreover, memset causes loss of sDecParam.sVideoProperty.size
that was set previously.

--- a/codec/console/dec/src/h264dec.cpp

+++ b/codec/console/dec/src/h264dec.cpp

@@ -344,7 +344,6 @@

         printf ("Specified file: %s not exist, maybe invalid path or parameter settting.\n", cReadCfg.GetFileName().c_str());

         return 1;

       }

-      memset (&sDecParam, 0, sizeof (sDecParam));

       while (!cReadCfg.EndOfFile()) {

         long nRd = cReadCfg.ReadLine (&strTag[0]);

@@ -382,7 +381,6 @@

     } else if (strstr (pArgV[1],

                        ".264")) { // no output dump yuv file, just try to render the decoded pictures //confirmed_safe_unsafe_usage

       strInputFile	= pArgV[1];

-      memset (&sDecParam, 0, sizeof (sDecParam));

       sDecParam.iOutputColorFormat          = videoFormatI420;

       sDecParam.uiTargetDqLayer	          = (uint8_t) - 1;

       sDecParam.uiEcActiveFlag	          = 1;

@@ -391,7 +389,6 @@

   } else { //iArgC > 2

     strInputFile	= pArgV[1];

     strOutputFile	= pArgV[2];

-    memset (&sDecParam, 0, sizeof (sDecParam));

     sDecParam.iOutputColorFormat	= videoFormatI420;

     sDecParam.uiTargetDqLayer	= (uint8_t) - 1;

     sDecParam.uiEcActiveFlag	= 1;