shithub: openh264

Download patch

ref: c4f01596207210eaf9effeb52f1dcf2859f47890
parent: ae73411f9ab5de7f104d8bc046fc9db8ec05f716
parent: ff5e6dde2ab2066e75bd243bc7a1748006610cd6
author: volvet <qizh@cisco.com>
date: Tue Jan 21 19:07:02 EST 2014 

Merge pull request #187 from licaiguo/fix-coverage-scan

fix issues found by coverage scan -- review request #58


--- a/codec/decoder/core/src/decoder_core.cpp
+++ b/codec/decoder/core/src/decoder_core.cpp
@@ -768,7 +768,6 @@
     } else if (uiQualityId > BASE_QUALITY_ID) {
       WelsLog (pCtx, WELS_LOG_WARNING, "MGS not supported.\n");
       return GENERATE_ERROR_NO (ERR_LEVEL_SLICE_HEADER, ERR_INFO_UNSUPPORTED_MGS);
-      pSliceHeadExt->uiRefLayerDqId	= pNalHeaderExt->uiLayerDqId - 1;
     } else {
       pSliceHeadExt->uiRefLayerDqId	= (uint8_t) - 1;
     }
@@ -1775,7 +1774,7 @@
     }
     GetI4LumaIChromaAddrTable (pCtx->iDecBlockOffsetArray, pCtx->pDec->iLinesize[0], pCtx->pDec->iLinesize[1]);
 
-    if (pNalCur->sNalHeaderExt.uiLayerDqId > kuiTargetLayerDqId) {
+    if (pNalCur->sNalHeaderExt.uiLayerDqId > kuiTargetLayerDqId) { // confirmed pNalCur will never be NULL
       break;	// Per formance it need not to decode the remaining bits any more due to given uiLayerDqId required, 9/2/2009
     }
 
--- a/codec/decoder/plus/src/welsCodecTrace.cpp
+++ b/codec/decoder/plus/src/welsCodecTrace.cpp
@@ -342,7 +342,7 @@
       break;
     default:
       if (m_fpDebugTrace)
-        m_fpInfoTrace ("%s", pStr);
+        m_fpDebugTrace ("%s", pStr);
       break;
     }
 #else