shithub: sox

Info  •  Files  •  Log  •  Branches

build: always pass -no-undefined to libtool

The -no-undefined flag is only required when building Windows DLLs.
Since we do not have any unresolved symbols in libsox, always using
the flag is harmless and simpler.

--- a/configure.ac

+++ b/configure.ac

@@ -91,12 +91,8 @@

       *linux* | *solaris*)

         LDFLAGS="$LDFLAGS -Wl,-z,defs"

         ;;

-      *os2* | *cygwin* | *mingw*)

-        APP_LDFLAGS="-no-undefined"

-        ;;

     esac

 fi

-AC_SUBST(APP_LDFLAGS)

 AC_ARG_WITH(distro,

     AS_HELP_STRING([--with-distro=name], [Provide distribution name]),

--- a/src/Makefile.am

+++ b/src/Makefile.am

@@ -88,7 +88,7 @@

 endif

 libsox_la_CFLAGS =

-libsox_la_LDFLAGS = @APP_LDFLAGS@ -version-info @SHLIB_VERSION@ \

+libsox_la_LDFLAGS = -no-undefined -version-info @SHLIB_VERSION@ \

   -export-symbols-regex '^(sox_.*|lsx_(([cm]|re)alloc.*|check_read_params|(close|open)_dllibrary|(debug(_more|_most)?|fail|report|warn)_impl|eof|error|fail_errno|filelength|find_(enum_(text|value)|file_extension)|flush|getopt(_init)?|lpc10_(create_(de|en)coder_state|(de|en)code)|raw(read|write)|read(_b_buf|buf|chars)|rewind|seeki|sigfigs3p?|strcasecmp|strdup|tell|unreadb|write(b|_b_buf|buf|s)))$$'

 if HAVE_LIBLTDL