shithub: sox

Info  •  Files  •  Log  •  Branches

Deprecate using "swap" with parameters

--- a/ChangeLog

+++ b/ChangeLog

@@ -31,6 +31,7 @@

   ated in  [F(ormat)] [E(ffect)]   Replacement             due after

   -------  ----------------------  ----------------------  -------

   14.4.0   E mixer                 remix                   14.4.0 + 1 year

+  14.4.0   E swap with parameters  remix                   14.4.0

 Previously deprecated features (to be removed in future):

--- a/src/swap.c

+++ b/src/swap.c

@@ -28,6 +28,9 @@

     priv_t * swap = (priv_t *) effp->priv;

   --argc, ++argv;

+    if (argc)

+      lsx_warn("Invoking this effect with parameters is deprecated; use `remix' instead.");

+

     swap->order[0] = swap->order[1] = swap->order[2] = swap->order[3] = 0;

     if (argc)

     {

@@ -181,7 +184,7 @@

 const sox_effect_handler_t *lsx_swap_effect_fn(void)

 {

   static sox_effect_handler_t handler = {

-    "swap", "[1 2 | 1 2 3 4]", SOX_EFF_MCHAN | SOX_EFF_MODIFY,

+    "swap", NULL, SOX_EFF_MCHAN | SOX_EFF_MODIFY,

     sox_swap_getopts, sox_swap_start, sox_swap_flow,

     NULL, NULL, NULL, sizeof(priv_t)

   };