shithub: sox

Info  •  Files  •  Log  •  Branches

Apply changes suggested in tracker patch 2909975 to fix effect flags for fade, remix, silence, and speed effects.

--- a/src/fade.c

+++ b/src/fade.c

@@ -364,7 +364,7 @@

   "[ type ] fade-in-length [ stop-time [ fade-out-length ] ]\n"

   "       Time is in hh:mm:ss.frac format.\n"

   "       Fade type one of q, h, t, l or p.",

-  SOX_EFF_MCHAN,

+  SOX_EFF_MCHAN | SOX_EFF_LENGTH,

   sox_fade_getopts,

   sox_fade_start,

   sox_fade_flow,

--- a/src/noisered.c

+++ b/src/noisered.c

@@ -1,4 +1,4 @@

-/* noiseprof - Noise Profiling Effect.

+/* noisered - Noise Reduction Effect.

  *

  * Written by Ian Turner (vectro@vectro.org)

  *

--- a/src/remix.c

+++ b/src/remix.c

@@ -251,7 +251,7 @@

 sox_effect_handler_t const * lsx_channels_effect_fn(void)

 {

   static sox_effect_handler_t handler = {

-    "channels", "number", SOX_EFF_MCHAN | SOX_EFF_CHAN | SOX_EFF_MODIFY,

+    "channels", "number", SOX_EFF_MCHAN | SOX_EFF_CHAN,

     channels_create, channels_start, flow, NULL, closedown, NULL, sizeof(priv_t)

   };

   return &handler;

--- a/src/silence.c

+++ b/src/silence.c

@@ -665,7 +665,7 @@

 static sox_effect_handler_t sox_silence_effect = {

   "silence",

   "[ -l ] above_periods [ duration thershold[d|%%] ] [ below_periods duration threshold[d|%%]]",

-  SOX_EFF_MCHAN | SOX_EFF_MODIFY,

+  SOX_EFF_MCHAN | SOX_EFF_MODIFY | SOX_EFF_LENGTH,

   sox_silence_getopts,

   sox_silence_start,

   sox_silence_flow,

--- a/src/speed.c

+++ b/src/speed.c

@@ -62,7 +62,8 @@

 sox_effect_handler_t const * lsx_speed_effect_fn(void)

 {

   static sox_effect_handler_t handler = {

-    "speed", "factor[c]",SOX_EFF_NULL|SOX_EFF_MCHAN|SOX_EFF_RATE|SOX_EFF_LENGTH,

+    "speed", "factor[c]",

+	SOX_EFF_MCHAN | SOX_EFF_RATE | SOX_EFF_LENGTH,

     getopts, start, lsx_flow_copy, 0, 0, 0, sizeof(priv_t)};

   return &handler;

 }