shithub: sox

Download patch

ref: c972f90f8d7f2e4ff8d2c865ef7b2f897a408de7
parent: b8b161f08345120c31866a190cde9aff566be4af
author: Mans Rullgard <mans@mansr.com>
date: Tue Aug 4 12:39:05 EDT 2020

ladspa: fix confusing indentation

GCC (correctly) warns about misleading indentation. Since the if clause
ends with a return, the else clause and anything following it are either
both executed or not at all.  The code is thus correct, if confusing.
Improve matters by removing the unnecessary else and fixing the
indentation.

--- a/src/ladspa.c
+++ b/src/ladspa.c
@@ -160,8 +160,8 @@
     if (l_st->desc == NULL) {
       lsx_fail("no plugin called `%s' found", argv[0]);
       return SOX_EOF;
-    } else
-      argc--; argv++;
+    }
+    argc--; argv++;
   }
 
   /* Scan the ports for inputs and outputs */