shithub: sox

Info  •  Files  •  Log  •  Branches

Fix [1890983] rec shortcut should apply bit depth; update some comments

--- a/ChangeLog

+++ b/ChangeLog

@@ -42,6 +42,8 @@

   o Fix [1864216] comments mangled when writing ogg-vorbis.  (robs)

   o Fix crash on 64-bit arch. with tempo & key effects.  (Sami Liedes)

+  o Fix [1890983] rec shortcut should apply bit depth (8-bit,

+    16-bit, etc.) to input handler.  (robs)

 Internal improvements:

@@ -59,7 +61,7 @@

   14.1.0   F flac: libFLAC 1.1.1   libFLAC > 1.1.1         14.1.0 + 6 months

   14.1.0   Behaviour whereby       soxi                    14.1.0 + 1 year

            sox -V file(s) -n

-	   doesn't read to EOF

+	   doesn't read to EOF.

 sox-14.0.1	2008-01-29

--- a/src/sox.c

+++ b/src/sox.c

@@ -717,8 +717,7 @@

   /* Loop through the rest of the arguments looking for effects */

   parse_effects(argc, argv);

-  /* Not the greatest way for users to do this perhaps, but they're used

-   * to it, so it ought to stay until we replace it with something better. */

+  /* Not the best way for users to do this; now deprecated in favour of soxi. */

   if (!nuser_effects && ofile->filetype && !strcmp(ofile->filetype, "null")) {

     for (i = 0; i < input_count; i++)

       report_file_info(files[i]);

@@ -725,6 +724,7 @@

     exit(0);

   }

+  /* Bit of a hack: input files can get # of chans from an effect */

   for (i = 0; i < input_count; i++) {

     unsigned j;

     for (j =0; j < nuser_effects && !files[i]->ft->signal.channels; ++j)