ref: 195217a48062c3ee64a47b1d0b5327e5838a105c
parent: 05b533d1f899e448fae25e27614543147f9acffa
author: Simon Tatham <anakin@pobox.com>
date: Tue Mar 24 15:20:03 EDT 2015
Fix a compile warning on ARM. Aapo Rantalainen points out that comparing 'char c' against zero gives rise to gcc's "comparison is always false" warning, which escalates to an error under -Werror. This is one of those situations where the warning is doing more harm than good, but here's a rephrasing which casts to unsigned so that both negative numbers and positive out-of-range ones can be caught by the same comparison.
--- a/flood.c
+++ b/flood.c
@@ -609,7 +609,7 @@
c = 10 + (c - 'A');
else
return "Bad character in grid description";
- if (c < 0 || c >= params->colours)
+ if ((unsigned)c >= params->colours)
return "Colour out of range in grid description";
}
if (*desc != ',')