ref: 19fa275b6a92d8c17a68bc4180985c98a145c33a
parent: c539872613510e9bc6b951db1ab93d3a3b7873ff
author: Simon Tatham <anakin@pobox.com>
date: Sun May 16 02:58:09 EDT 2010
Patch from Ben Hutchings to fix an error-checking goof: Keen division clues were failing to light up as erroneous if the quotient of the numbers in them came out right under rounded-down C integer division (e.g. 2 and 5 would be accepted for a 2/ clue). Apparently I copied the code that invents clues in the generator straight into the solution checker, without remembering that the generator was allowed to do it that way because exact divisibility had been checked elsewhere. [originally from svn r8951]
--- a/keen.c
+++ b/keen.c
@@ -1450,11 +1450,12 @@
break;
case C_DIV:
{- int d1 = cluevals[j], d2 = state->grid[i];
- if (d1 == 0 || d2 == 0)
+ int d1 = min(cluevals[j], state->grid[i]);
+ int d2 = max(cluevals[j], state->grid[i]);
+ if (d1 == 0 || d2 % d1 != 0)
cluevals[j] = 0;
else
- cluevals[j] = d2/d1 + d1/d2;/* one of them is 0 :-) */
+ cluevals[j] = d2 / d1;
}
break;
}