shithub: puzzles

Download patch

ref: 4a8edc65bbe906093787645b98122c7750ae83e8
parent: 3017455259f955e6257381e449419fea780a40f2
author: Simon Tatham <anakin@pobox.com>
date: Wed Oct 29 17:41:38 EDT 2014

Fix error highlighting of closed subgraphs in Bridges.

When I did the recent rewrite of the Bridges drawing code, I spotted
and replicated the code in game_redraw that set G_WARN at redraw time
on an island with unsatisfiable clues, but didn't spot the code
elsewhere (e.g. map_group_check) which might have set G_WARN ahead of
time, so I failed to check for that. As a result, if you join some
islands together into a subgraph with no further room for expansion
(e.g. connect a pair of 1s together, or a pair of 2s with a double
bridge) then all the bridges in that subgraph light up red but the
islands themselves forget to.

Trivial one-line fix.

--- a/bridges.c

+++ b/bridges.c

@@ -2967,7 +2967,7 @@

                 if (is_drag_src && (is == is_drag_src ||

                                     (is_drag_dst && is == is_drag_dst)))

                     idata |= DI_COL_SELECTED;

-                else if (island_impossible(is, v & G_MARK))

+                else if (island_impossible(is, v & G_MARK) || (v & G_WARN))

                     idata |= DI_COL_WARNING;

                 else

                     idata |= DI_COL_NORMAL;