shithub: puzzles

Info  •  Files  •  Log  •  Branches

js: When making a hidden element visible, just remove "display: none"

This removes any assumption in the JavaScript code about precisely what
"display" setting the element should have.

This means that now the only places where the JavaScript manipulates
elements' styles are to set the width of the puzzle container and to
mark and unmark elements with "display: none".  These both seem like
reasonable kinds of semantic markup that just happen to be expressed as
styles.

--- a/emcclib.js

+++ b/emcclib.js

@@ -173,7 +173,7 @@

         } else {

             seed = UTF8ToString(seed);

             permalink_seed.href = "#" + seed;

-            permalink_seed.style.display = "inline";

+            permalink_seed.style.display = "";

         }

     },

--- a/emccpre.js

+++ b/emccpre.js

@@ -522,6 +522,6 @@

         // it's probably safe to hide the 'sorry, no puzzle here' div and

         // show the div containing the actual puzzle.

         document.getElementById("apology").style.display = "none";

-        document.getElementById("puzzle").style.display = "inline";

+        document.getElementById("puzzle").style.display = "";

     };

 }