ref: e8ac0381f976f2dfd70fbe52e0ec59c1a8da9df6
parent: 26c7f3aa285a45176c940afebe3885ad2be2ed65
author: Ben Harris <bjh21@bjh21.me.uk>
date: Sat Feb 18 13:52:21 EST 2023
Convert a lot of floating-point constants to single precision For reasons now lost to history, Puzzles generally uses single-precision floating point. However, C floating-point constants are by default double-precision, and if they're then operated on along with a single-precision variable the value of the variable gets promoted to double precision, then the operation gets done, and then often the result gets converted back to single precision again. This is obviously silly, so I've used Clang's "-Wdouble-promotion" to find instances of this and mark the constants as single-precision as well. This is a bit awkward for PI, which ends up with a cast. Maybe there should be a PIF, or maybe PI should just be single-precision. This doesn't eliminate all warnings from -Wdouble-promotion. Some of the others might merit fixing but adding explicit casts to double just to shut the compiler up would be going too far, I feel.